Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed pressed and focused color token #2444

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Powerplex
Copy link
Contributor

dsign token are removed, making some tailwind classes invalid

BREAKING CHANGE: all -pressed and -focused suffixed tailwind classes must be replaced by -hovered variant

TASK: #2440

Description, Motivation and Context

Theme color tokens goes from 123 colors to 77 colors, by removing all -pressed and -focused color tokens (unused by designers and apps, their values were always identical to their -hovered counterpart)

Types of changes

  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧠 Refactor
  • 💄 Styles

dsign token are removed, making some tailwind classes invalid

BREAKING CHANGE: all -pressed and -focused suffixed tailwind classes must be replaced by -hovered
variant
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (6cedb77) to head (7396d0e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2444   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         515      515           
  Lines        4366     4366           
  Branches     1406     1406           
=======================================
  Hits         4210     4210           
  Misses        152      152           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Powerplex Powerplex merged commit b84b045 into main Oct 2, 2024
10 checks passed
@Powerplex Powerplex deleted the rm-useless-color-tokens branch October 2, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants